IGNITE-27155 BinaryWriterExImpl#failIfUnregistered can be final#12528
Merged
nizhikov merged 3 commits intoapache:masterfrom Nov 24, 2025
Merged
IGNITE-27155 BinaryWriterExImpl#failIfUnregistered can be final#12528nizhikov merged 3 commits intoapache:masterfrom
nizhikov merged 3 commits intoapache:masterfrom
Conversation
timoninmaxim
requested changes
Nov 24, 2025
| */ | ||
| public interface BinaryWriterEx extends BinaryWriter, BinaryRawWriter, ObjectOutput { | ||
| /** Default value for {@link #failIfUnregistered()}. */ | ||
| public static final boolean DFLT_FAIL_IF_UNREGISTERED = false; |
Member
There was a problem hiding this comment.
I suppose it should be defined in BinaryWriterExImpl.
| * @return Writer instance. | ||
| */ | ||
| public static BinaryWriterEx writer(BinaryContext ctx) { | ||
| public static BinaryWriterEx writer(BinaryContext ctx, boolean failIfUnregistered) { |
|
timoninmaxim
approved these changes
Nov 24, 2025
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.